He continued: "But it also means proper authorship and committer information etc. Torvalds' chief problem with it was that merges need "proper commit messages with information about is being merged and *why* you merge something." He continued: "That's another of those things that I *really* don't want to see - GitHub creates absolutely useless garbage merges, and you should never ever use the GitHub interfaces to merge anything.GitHub is a perfectly fine hosting site, and it does a number of other things well too, but merges are not one of those things." "I notice that you have a GitHub merge commit in there," wrote Torvalds. Via The Register, Torvalds offered Komarov a few pointers on how not to submit pull requests in the future, especially using GitHub's web interface for any code merges into the Linux kernel. Hopefully, it is ok - no regression was detected in tests." "Most of the code was in the Linux-next branch since Aug 13, but there are some patches that were in the Linux-next branch only for a couple of days.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |